Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Local Settings UI: Overlay messages on save and reset #3104

Merged
merged 7 commits into from
Apr 26, 2022
Merged

Local Settings UI: Overlay messages on save and reset #3104

merged 7 commits into from
Apr 26, 2022

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Apr 26, 2022 •
edited
Loading

Brief description

Added overlay messages logic used in local settings UI.

Description

Implemented MessageOverlayObject which shows messages in a window that will disappear after timeout. This overlay object is used in local settings to tell user that were saved.

Testing notes:

  1. Open local settings
  2. Hit save (or reset)

Screenshot

image

Resolves #3039

@iLLiCiTiT iLLiCiTiT self-assigned this Apr 26, 2022
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Apr 26, 2022
m-u-r-p-h-y
m-u-r-p-h-y approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

fixing #3039

@iLLiCiTiT iLLiCiTiT merged commit 3092ba5 into develop Apr 26, 2022
@iLLiCiTiT iLLiCiTiT deleted the enhancement/overlay_messages_object branch April 26, 2022 11:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@m-u-r-p-h-y m-u-r-p-h-y m-u-r-p-h-y approved these changes

@kalisp kalisp Awaiting requested review from kalisp

@mkolar mkolar Awaiting requested review from mkolar

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OP Local settings save confirmation
2 participants
@iLLiCiTiT @m-u-r-p-h-y